[ovs-dev] [PATCH] xenserver: Set network-uuid for internal bridges

Justin Pettit jpettit at nicira.com
Wed Oct 28 19:08:08 UTC 2009


On Oct 28, 2009, at 11:59 AM, Ben Pfaff wrote:

> Justin Pettit <jpettit at nicira.com> writes:
>
>> +    local internal=$(${vif_on_internal_bridge} ${DOMID} ${DEVID})
>> +    if [ $internal = "true" ]; then
>
> Please quote $internal as "$internal", in case the
> vif_on_internal_bridge script encounters an error.
>
> Otherwise it looks fine to me, as long as it works.


Thanks for the feedback.  I've added your change and pushed.

--Justin







More information about the dev mailing list