[ovs-dev] [PATCH] ofproto: Only zero stats for non exact-match sub-rules.

Jesse Gross jesse at nicira.com
Fri Oct 30 21:27:01 UTC 2009


We zero the stats on sub-rules after they expire to prevent them
from being counted twice in their super-rule if they are reinstalled.
However, for exact-match sub-rules this means that the OpenFlow stats
are always zero.  This changes that to only zero the stats for
non exact match rules.

Bug #1911
---
 secchan/ofproto.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/secchan/ofproto.c b/secchan/ofproto.c
index 7fb0c64..4266cbf 100644
--- a/secchan/ofproto.c
+++ b/secchan/ofproto.c
@@ -1731,15 +1731,15 @@ rule_post_uninstall(struct ofproto *ofproto, struct rule *rule)
         if (rule->packet_count) {
             super->ip_tos = rule->ip_tos;
         }
-    }
 
-    /* Reset counters to prevent double counting if the rule ever gets
-     * reinstalled. */
-    rule->packet_count = 0;
-    rule->byte_count = 0;
-    rule->accounted_bytes = 0;
-    rule->tcp_flags = 0;
-    rule->ip_tos = 0;
+        /* Reset counters to prevent double counting if the rule ever gets
+         * reinstalled. */
+        rule->packet_count = 0;
+        rule->byte_count = 0;
+        rule->accounted_bytes = 0;
+        rule->tcp_flags = 0;
+        rule->ip_tos = 0;
+    }
 }
 
 static void
-- 
1.6.0.4





More information about the dev mailing list