[ovs-dev] [ovs-discuss] WARN_ON_ONCE in dp_output_control

Ben Pfaff blp at nicira.com
Tue Sep 1 17:12:35 UTC 2009

Ian Campbell <Ian.Campbell at eu.citrix.com> writes:

> On Fri, 2009-08-28 at 17:36 +0100, Ben Pfaff wrote:
>> Ian Campbell <Ian.Campbell at citrix.com> writes:
>> > I've just updated our internal tree to use current head vswitch
>> > (0babc06fb3cd2a6c80d730e3a8dda64cf6298500 "vswitchd: Fix bug in Ethernet
>> > address selection for bridge.") and I am seeing the WARN_ON_ONCE at
>> > datapath.c:659 triggering. (I might have been seeing it before and not
>> > noticed so the fact I've just updated might be irrelevant). The kernel
>> > is 2.6.27 based.
>> >
>> > Is the warning actually necessary or is this a normal (and correctly
>> > handled) occurrence?
>> I inserted this WARN_ON_ONCE() because at the time I had no way
>> to easily test the code on that side of the #if fork: it seemed
>> difficult or impossible to trigger the condition on anything but
>> Xen, and Xen Dom0 didn't have a new enough kernel (at least as
>> far as I know).
>> But if you've started seeing this then I should probably commit
>> the following.  Comments?
> Looks ok to me.

Thanks.  I pushed this out.

More information about the dev mailing list