[ovs-dev] [L3 In-Band 7/9] netdev: Add netdev_get_next_hop call

Justin Pettit jpettit at nicira.com
Tue Sep 1 21:52:29 UTC 2009


On Aug 31, 2009, at 5:13 PM, Ben Pfaff wrote:

> In the error case, would you mind making netdev_get_next_hop()
> set next_hop->s_addr to some predictable value (perhaps 0)?  In
> my experience this kind of consistency can make programs easier
> to debug.

This is how I originally implemented it, but doing it this way made  
the code a bit cleaner for the caller.  I didn't feel strongly,  
though, so I've implemented it the way you've suggested here.  I've  
also integrated your other suggestions.

--Justin






More information about the dev mailing list