[ovs-dev] [PATCH] datapath: Don't drop MTU-sized VLAN packets from userspace
Justin Pettit
jpettit at nicira.com
Sat Sep 5 06:11:16 UTC 2009
On Sep 4, 2009, at 9:40 PM, Ben Pfaff wrote:
> Should there be a comment saying that we're doing a subset of
> what eth_type_trans() would otherwise do?
Good idea. I added it.
> Should we do the funny test for Netware packets that
> eth_type_trans() does?
I left it out, since it said it was for older Netware, which must be
ancient. When I was running across Netware in the mid-90s, it was
using 802.2 LLC, so that must be really old. I left it out, since I
can't imagine we'll run into it, and it just seemed to complicate
things. I don't feel strongly, though, so let me know if you (or
anyone else out there) want me to add it.
Thanks for the review. I pushed the changes and merged them into
master.
--Justin
More information about the dev
mailing list