[ovs-dev] [PATCH 1/5] Do not renice the netback thread.
blp at nicira.com
Wed Sep 9 17:53:10 UTC 2009
Justin Pettit <jpettit at nicira.com> writes:
> On Sep 9, 2009, at 6:16 PM, Ben Pfaff wrote:
>> Ian Campbell <ian.campbell at citrix.com> writes:
>>> We should increase the vswitchd daemon's priority instead.
>> Patches 1 and 2 look OK from a technical point of view, but I
>> wonder if it would be more flexible to just do something like the
>> following patch in place of these two. In other words, instead
>> of dropping the ability to change netback's priority, just turn
>> it off for now. That would preserve our flexibility in case we
>> change our minds later for whatever reason.
> I guess my concern is that we shouldn't be mucking with other
> processes' priorities. Theoretically, they've been tested and known
> to work at whatever level was originally configured. Doing it the way
> you've proposed obviously doesn't cause any harm, but by providing it
> as an option, users are more likely to mess things up by thinking it's
> an approved tweakable parameter.
Fair enough, I guess.
I pushed these to master without changes. I also crossported
them to citrix and pushed those changes out too.
More information about the dev