[ovs-dev] [PATCH 3/5] Move vswitch state files to /var/lib.

Ian Campbell Ian.Campbell at eu.citrix.com
Thu Sep 10 08:22:54 UTC 2009


On Wed, 2009-09-09 at 18:20 +0100, Ben Pfaff wrote:
> Ian Campbell <ian.campbell at citrix.com> writes:
> 
> > I believe this is the correct location for files of this type.
> 
> Yes, I agree, this looks good.
> 
> It would be better, I think, to create the directory by packaging
> it into the RPM.

Agreed. The spec file I am using is a different one which is much
simpler because it can omit all of the logic needed to make the addon
version safe but does this. The version currently in openvswitch.git
still uses /root/vswitch so I'm not sure what the correct patch is, it's
just a mkdir (or equivalent) in %install and a %dir statement under
%files though.

> 
> I'm not all that happy about the need for the
> /var/lib/openvswitch/br-* files at all, by the way.  It doesn't
> seem like a great way to communicate with the vif script.  But I
> don't have a better suggestion at the moment.

They aren't ideal, although I think they do for now.
 
Longer term xapi could write the VLAN tag, and possibly the underlying
bridge name (i.e. not the VLAN bridge which we already have access to bu
the bond or physical bridge) to xenstore, the vif hotplug script already
picks up a bunch of its config from here.

Ian.






More information about the dev mailing list