[ovs-dev] [PATCH 2/4] xenserver: Set default file log level and fix brcompatd file log config

Ben Pfaff blp at nicira.com
Fri Sep 11 17:09:17 UTC 2009

Justin Pettit <jpettit at nicira.com> writes:

> Set the default log level for file logging to INFO for ovs-vswitchd and
> ovs-brcompatd.  Fix test for whether file logging should be enabled for
> ovs-brcompatd.

I would add part of the patch 1/4 commit log to this to explain
why it's being done.

> @@ -169,7 +169,7 @@ function start_brcompatd {
>          mkdir -p "$BRCOMPATD_RUN_DIR"
>      fi
>      cd "$BRCOMPATD_RUN_DIR"
> -    if [ ! -n "$BRCOMPATD_FILE_LOGLEVEL" ]; then
> +    if [ -n "$BRCOMPATD_FILE_LOGLEVEL" ]; then

Dunno if you care, but for what it's worth, this "if" will always
be true, since at the top of the file we set
$BRCOMPATD_FILE_LOGLEVEL to info if it's an empty string.

>          logfile_level_opt="-vANY:FILE:${BRCOMPATD_FILE_LOGLEVEL}"
>          logfile_file_opt="--log-file=$BRCOMPATD_LOGFILE"
>      fi

More information about the dev mailing list