[ovs-dev] [PATCH 1/2] datapath: Fix comments.

Justin Pettit jpettit at nicira.com
Sat Sep 12 13:42:30 UTC 2009


Looks good.

--Justin


On Sep 12, 2009, at 12:53 AM, Ben Pfaff wrote:

> ---
> datapath/datapath.c |    4 +---
> datapath/datapath.h |    1 -
> 2 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 427391a..52941e7 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -56,9 +56,7 @@ int (*dp_ioctl_hook)(struct net_device *dev,  
> struct ifreq *rq, int cmd);
> EXPORT_SYMBOL(dp_ioctl_hook);
>
> /* Datapaths.  Protected on the read side by rcu_read_lock, on the  
> write side
> - * by dp_mutex.  dp_mutex is almost completely redundant with  
> genl_mutex
> - * maintained by the Generic Netlink code, but the timeout path  
> needs mutual
> - * exclusion too.
> + * by dp_mutex.
>  *
>  * dp_mutex nests inside the RTNL lock: if you need both you must  
> take the RTNL
>  * lock first.
> diff --git a/datapath/datapath.h b/datapath/datapath.h
> index 122706a..ab9359e 100644
> --- a/datapath/datapath.h
> +++ b/datapath/datapath.h
> @@ -14,7 +14,6 @@
> #include <asm/page.h>
> #include <linux/kernel.h>
> #include <linux/mutex.h>
> -#include <linux/netlink.h>
> #include <linux/netdevice.h>
> #include <linux/workqueue.h>
> #include <linux/skbuff.h>
> -- 
> 1.6.3.3
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list