[ovs-dev] [PATCH] vswitch: Correctly identify slave status in /proc compatibility layer
Ben Pfaff
blp at nicira.com
Mon Sep 14 16:12:56 UTC 2009
Justin Pettit <jpettit at nicira.com> writes:
> In the /proc compatibility layer, the bond member was reported as up
> immediately after link recovery, regardless of the updelay. I believe
> the compatibility code was correct if the check had been done with carrier,
> but since 'iface->enabled' already does that calculation, we can use it
> directly.
My reading of the kernel bonding code was that that particular
value in /proc actually reports the carrier status, not whether
the slave is enabled or disabled. If I'm wrong, this commit
should be applied. If I'm right, I think that the code was
correct.
> Additinally, when a bond slave was enabled or disabled, the bond
> compatibility code was not being told to update its state. This commit
> makes that call.
That part looks good.
More information about the dev
mailing list