[ovs-dev] [PATCH 1/2] secchan: Fix bad pointer dereference sending flow expirations.

Ben Pfaff blp at nicira.com
Tue Sep 15 00:03:39 UTC 2009


Thanks, I pushed commit 1/2 out.

Jesse Gross <jesse at nicira.com> writes:

> Looks good.
>
> Ben Pfaff wrote:
>> ---
>>  secchan/ofproto.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/secchan/ofproto.c b/secchan/ofproto.c
>> index 6097d57..105e43e 100644
>> --- a/secchan/ofproto.c
>> +++ b/secchan/ofproto.c
>> @@ -3157,7 +3157,7 @@ send_flow_exp(struct ofproto *p, struct rule *rule,
>>      LIST_FOR_EACH (ofconn, struct ofconn, node, &p->all_conns) {
>>          if (ofconn->send_flow_exp && rconn_is_connected(ofconn->rconn)) {
>>              if (prev) {
>> -                queue_tx(ofpbuf_clone(buf), prev, ofconn->reply_counter);
>> +                queue_tx(ofpbuf_clone(buf), prev, prev->reply_counter);
>>              } else {
>>                  buf = compose_flow_exp(rule, now, reason);
>>              }
>> @@ -3165,7 +3165,7 @@ send_flow_exp(struct ofproto *p, struct rule *rule,
>>          }
>>      }
>>      if (prev) {
>> -        queue_tx(buf, prev, ofconn->reply_counter);
>> +        queue_tx(buf, prev, prev->reply_counter);
>>      }
>>  }
>>    




More information about the dev mailing list