[ovs-dev] [PATCH] xenserver: Fix detection of xs-network-uuids in interface-reconfigure.

Ben Pfaff blp at nicira.com
Tue Sep 15 21:39:34 UTC 2009


Thanks.

Reid also expressed approval of this, over IM.

Pushed.

Justin Pettit <jpettit at nicira.com> writes:

> Looks good to me.
>
> --Justin
>
>
> On Sep 15, 2009, at 10:21 PM, Ben Pfaff wrote:
>
>> Commit c798b21c6a "xenserver: Only consider the host we are running
>> on in
>> interface-reconfigure" dropped the get_pifs_by_record function in
>> favor
>> of get_pifs_by_device, but didn't adapt callers properly, so that the
>> XenServer network PIFs weren't properly found and thus the xs-
>> network-uuids
>> keys weren't set correctly.
>>
>> This fixes the caller.
>>
>> Bug #2043.
>> ---
>> .../opt_xensource_libexec_interface-reconfigure    |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/xenserver/opt_xensource_libexec_interface-reconfigure
>> b/
>> xenserver/opt_xensource_libexec_interface-reconfigure
>> index 13c6888..07e7ba2 100755
>> --- a/xenserver/opt_xensource_libexec_interface-reconfigure
>> +++ b/xenserver/opt_xensource_libexec_interface-reconfigure
>> @@ -1191,7 +1191,7 @@ def action_up(pif):
>>     # - The networks corresponding to any VLANs attached to the
>>     #   datapath's PIF.
>>     network_uuids = []
>> -    for nwpif in db.get_pifs_by_device({'device': pifrec['device']}):
>> +    for nwpif in db.get_pifs_by_device(pifrec['device']):
>>         net = db.get_pif_record(nwpif)['network']
>>         network_uuids += [db.get_network_record(net)['uuid']]
>>
>> --
>> 1.6.3.3
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org




More information about the dev mailing list