[ovs-dev] [PATCH 2/2] vswitchd: Fix unimportant memory leak.

Justin Pettit jpettit at nicira.com
Thu Sep 17 21:57:21 UTC 2009


Looks good.

--Justin


On Sep 17, 2009, at 2:46 PM, Ben Pfaff wrote:

> Free dpif_names when we're done with it.
>
> This memory leak is not a big deal since bridge_init() is only ever  
> called
> once in a given ovs-vswitchd execution.
> ---
> vswitchd/bridge.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 6b7502b..ac993bf 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -312,6 +312,7 @@ bridge_init(void)
>             dpif_close(dpif);
>         }
>     }
> +    svec_destroy(&dpif_names);
>
>     unixctl_command_register("bridge/dump-flows",  
> bridge_unixctl_dump_flows);
>
> -- 
> 1.6.3.3
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list