[ovs-dev] [PATCH 0/4] Fix memory leak in vconn-unix code.

Justin Pettit jpettit at nicira.com
Mon Sep 21 23:42:25 UTC 2009


The set looks reasonable to me.

--Justin


On Sep 21, 2009, at 2:53 PM, Ben Pfaff wrote:

> This memory leak is present in both the citrix and master branches,  
> but
> the proper fix is somewhat invasive and the leak is not so  
> important, so
> I am proposing this series of changes as a fix only for the master  
> branch.
>
> Fixes for more serious memory leaks have already been posted.
>
> Ben Pfaff (4):
>  vconn: Remove unused "reconnectable" member from vconn.
>  fatal-signal: Clean up code by using shash.
>  fatal-signal: New function fatal_signal_unlink_file_now().
>  vconn-unix: Unlink Unix sockets for vconns at close and free memory.
>
> lib/fatal-signal.c   |   44 +++++++++++++++++++++++++++--------------
> lib/fatal-signal.h   |    3 +-
> lib/unixctl.c        |    6 +---
> lib/vconn-provider.h |    3 +-
> lib/vconn-ssl.c      |    2 +-
> lib/vconn-stream.c   |   52 +++++++++++++++++++++++++++++++++++++++++ 
> +++-----
> lib/vconn-stream.h   |    3 +-
> lib/vconn-tcp.c      |    4 +-
> lib/vconn-unix.c     |   14 +++++++-----
> lib/vconn.c          |   20 +++++++++++++++++-
> lib/vlog-modules.def |    1 +
> 11 files changed, 112 insertions(+), 40 deletions(-)
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list