[ovs-dev] [PATCH] brcompatd: Delete VLAN tags only for the correct port in del_port().

Justin Pettit jpettit at nicira.com
Tue Sep 22 17:05:26 UTC 2009


That seems reasonable to me.

--Justin


On Sep 21, 2009, at 3:43 PM, Ben Pfaff wrote:

> vlan.%s.* will match e.g. eth0.123 if the %s expands to eth0.  We only
> want it to match eth0 in that case.
>
> This is based on code inspection.  It may or may not fix a real  
> problem.
> ---
> vswitchd/ovs-brcompatd.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vswitchd/ovs-brcompatd.c b/vswitchd/ovs-brcompatd.c
> index 50ed632..13bb843 100644
> --- a/vswitchd/ovs-brcompatd.c
> +++ b/vswitchd/ovs-brcompatd.c
> @@ -525,7 +525,7 @@ del_port(const char *br_name, const char  
> *port_name)
> {
>     cfg_del_entry("bridge.%s.port=%s", br_name, port_name);
>     cfg_del_match("bonding.*.slave=%s", port_name);
> -    cfg_del_match("vlan.%s.*", port_name);
> +    cfg_del_match("vlan.%s.[!0-9]*", port_name);
> }
>
> static int
> -- 
> 1.6.3.3
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list