[ovs-dev] [PATCH] Document per-port round-robin during controller rate limiting.

Justin Pettit jpettit at nicira.com
Tue Sep 22 17:22:20 UTC 2009

On Sep 22, 2009, at 9:33 AM, Ben Pfaff wrote:

> +In addition, when a high rate triggers rate limiting, Open vSwitch

Should this be "rate-limiting"?  To be consistent with the rest of the  
man page, I would change "Open vSwitch" to "\fBovs\-vswitchd\fR".

> +queues controller packets for each port, up to a total of \fIburst\fR

"burst" doesn't get defined until the "burst-limit" key is discussed a  
few paragraphs down.

> +packets across all ports on the bridge.  A port queue balancing

Is this evenly distributed (ie, if there are N ports, then each gets  
burst/N message slots)?

> +algorithm prevents a single port on a bridge from monopolizing the
> +resources for forwarding packets for unknown flows on a given bridge.

Doesn't this apply to both unknown flows and explicit actions?  That  
seems to be the implication in the following paragraph.

> +.PP
> +Open vSwitch maintains two such packet rate-limiters per bridge.  One

Once again, we typically call it by its binary name.

> +of these applies to packets sent up to the controller because they do
> +not correspond to any flow.  The other applies to packets sent up to
> +the controller by request through flow actions.  When both
> +rate-limiters are filled with packets, the actual rate that packets
> +are sent to the controller is up to twice the specified rate.

The rest looked fine to me.


More information about the dev mailing list