[ovs-dev] [PATCH] shash: Fix memory leak in shash_destroy().

Justin Pettit jpettit at nicira.com
Thu Sep 24 17:45:11 UTC 2009


Looks good to me.

--Justin


On Sep 24, 2009, at 10:23 AM, Ben Pfaff wrote:

> hmap_destroy() has to be called so that sh->map.buckets gets freed.
> ---
> lib/shash.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/shash.c b/lib/shash.c
> index 9ddafe0..520e189 100644
> --- a/lib/shash.c
> +++ b/lib/shash.c
> @@ -36,6 +36,7 @@ shash_destroy(struct shash *sh)
> {
>     if (sh) {
>         shash_clear(sh);
> +        hmap_destroy(&sh->map);
>     }
> }
>
> -- 
> 1.6.3.3
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list