[ovs-dev] [PATCH 4/9] debian: Bring Debian packaging in-line with new file locations

Ben Pfaff blp at nicira.com
Fri Apr 2 16:39:31 UTC 2010


On Wed, Mar 31, 2010 at 08:21:22PM -0700, Justin Pettit wrote:
> diff --git a/debian/openvswitch-switch.logrotate b/debian/openvswitch-switch.logrotate
> index 3da57e0..6cc2ec3 100644
> --- a/debian/openvswitch-switch.logrotate
> +++ b/debian/openvswitch-switch.logrotate
> @@ -1,4 +1,4 @@
> -/var/log/openvswitch/ovs-openflowd.log {
> +/var/log/openvswitch/* {
>          daily
>          compress
>          create 640 root adm

I wonder whether the above should be *.log instead of *.  * will match
the rotated files too.  Maybe it doesn't matter (I don't know logrotate
very well).

> @@ -6,6 +6,7 @@
>          missingok
>          rotate 30
>          postrotate
> -                ovs-appctl --target=ovs-openflowd vlog/reopen
> +                ovs-appctl --t ovs-vswitchd vlog/reopen
> +                ovs-appctl --t ovsdb-server vlog/reopen
>          endscript

In the XenServer version we only call these commands if the
corresponding pidfile exists, for what it's worth.

Looks good otherwise.




More information about the dev mailing list