[ovs-dev] [PATCH] ovs-ofctl: Add support for "resubmit" Nicira vendor extension.

Justin Pettit jpettit at nicira.com
Fri Apr 2 22:53:41 UTC 2010


On Apr 2, 2010, at 2:26 PM, Ben Pfaff wrote:

> +This action is a Nicira vendor extension that as of this writing is
> +only known to be implemented by Open vSwitch.

Should the "as of this writing" be offset by commas?

> +.
> .RE
> .
> .IP
> diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> index 9a75969..33d3d23 100644
> --- a/utilities/ovs-ofctl.c
> +++ b/utilities/ovs-ofctl.c
> @@ -627,6 +627,12 @@ str_to_action(char *str, struct ofpbuf *b)
>             struct ofp_action_nw_tos *nt;
>             nt = put_action(b, sizeof *nt, OFPAT_SET_NW_TOS);
>             nt->nw_tos = str_to_u32(arg);
> +        } else if (!strcasecmp(act, "submit")) {

Shouldn't this be "resubmit"?

Otherwise, it looks good.

--Justin






More information about the dev mailing list