[ovs-dev] [PATCH] ovs-ofctl: Add support for "resubmit" Nicira vendor extension.

[Ben Pfaff]

On Fri, Apr 02, 2010 at 03:53:41PM -0700, Justin Pettit wrote:
> On Apr 2, 2010, at 2:26 PM, Ben Pfaff wrote:
> 
> > +This action is a Nicira vendor extension that as of this writing is
> > +only known to be implemented by Open vSwitch.
> 
> Should the "as of this writing" be offset by commas?

Sure.

> > +.
> > .RE
> > .
> > .IP
> > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> > index 9a75969..33d3d23 100644
> > --- a/utilities/ovs-ofctl.c
> > +++ b/utilities/ovs-ofctl.c
> > @@ -627,6 +627,12 @@ str_to_action(char *str, struct ofpbuf *b)
> >             struct ofp_action_nw_tos *nt;
> >             nt = put_action(b, sizeof *nt, OFPAT_SET_NW_TOS);
> >             nt->nw_tos = str_to_u32(arg);
> > +        } else if (!strcasecmp(act, "submit")) {
> 
> Shouldn't this be "resubmit"?

Yes.

> Otherwise, it looks good.

Thanks, I fixed those two issues and pushed.