[ovs-dev] [PATCH 2/2] xenserver: Don't install xsconsole plugin as symlink

[Justin Pettit]

On Apr 5, 2010, at 8:43 PM, Ben Pfaff wrote:

> On Mon, Apr 05, 2010 at 08:36:42PM -0700, Justin Pettit wrote:
>> On an upgrade, the Citrix packaging would attempt to cleanup files that were
>> in its packaging, but not in the upgraded package.  Since it didn't know
>> that we had replaced their plugin with our symlink, it would destroy our
>> symlink.
> 
> Did the Citrix packaging really do this (I mean, is it really in an RPM
> scriptlet?), or was did RPM just do it as a side effect of how it
> manages upgrades?

The latter.  I can add a clarifying comment if you'd like.

>> This commit just places the plugin directly into the
>> /usr/lib/xsconsole/plugins-base directory, which allows us to seamlessly
>> upgrade to newer Open vSwitch versions.
> 
> I guess you must have run this through the Nicira-internal autobuilder?
> It always finds packaging bugs for me whenever I accumulate enough
> hubris to push a change without checking it there first.


I can barely get things by you when I do test them, so you've got to believe I gave this a spin.  :)  It did build and seems to have fixed the problem.  Should I push?

--Justin