[ovs-dev] [PATCH] dpif: Really don't log many dpif errors.

Ben Pfaff blp at nicira.com
Tue Apr 6 18:17:44 UTC 2010


The comment here was out of touch with the actual definition.  Limiting a
log message to 9999 per minute is not much of a limit!

I suspect that I turned this way up during initial development at some
point and forgot to turn it down to a reasonable level.
---
 lib/dpif.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dpif.c b/lib/dpif.c
index 315f11f..8e5cf9f 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -58,7 +58,7 @@ static struct shash dpif_classes = SHASH_INITIALIZER(&dpif_classes);
 static struct vlog_rate_limit dpmsg_rl = VLOG_RATE_LIMIT_INIT(600, 600);
 
 /* Not really much point in logging many dpif errors. */
-static struct vlog_rate_limit error_rl = VLOG_RATE_LIMIT_INIT(9999, 5);
+static struct vlog_rate_limit error_rl = VLOG_RATE_LIMIT_INIT(60, 5);
 
 static void log_operation(const struct dpif *, const char *operation,
                           int error);
-- 
1.6.6.1





More information about the dev mailing list