[ovs-dev] [PATCH 05/14] ofproto: Make valgrind happy.
Ben Pfaff
blp at nicira.com
Fri Apr 9 00:07:03 UTC 2010
The "flags" member of struct odp_flow is not used for adding or deleting
flows, but valgrind doesn't know that. By zeroing it out we can suppress
spurious warnings.
---
ofproto/ofproto.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index fd1256f..a480a27 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -1669,6 +1669,7 @@ do_put_flow(struct ofproto *ofproto, struct rule *rule, int flags,
put->flow.key = rule->cr.flow;
put->flow.actions = rule->odp_actions;
put->flow.n_actions = rule->n_odp_actions;
+ put->flow.flags = 0;
put->flags = flags;
return dpif_flow_put(ofproto->dpif, put);
}
@@ -1764,6 +1765,7 @@ rule_uninstall(struct ofproto *p, struct rule *rule)
odp_flow.key = rule->cr.flow;
odp_flow.actions = NULL;
odp_flow.n_actions = 0;
+ odp_flow.flags = 0;
if (!dpif_flow_del(p->dpif, &odp_flow)) {
update_stats(p, rule, &odp_flow.stats);
}
--
1.6.6.1
More information about the dev
mailing list