[ovs-dev] [PATCH 3/4] xenserver: Allow use first class datamodel field for controller IP

Ben Pfaff blp at nicira.com
Mon Apr 12 16:56:00 UTC 2010

On Sun, Apr 11, 2010 at 11:18:34PM -0700, Justin Pettit wrote:
> Starting in XenServer 5.6.0, a "vswitch_controller" key is available to
> store the controller's IP address in the "pool" table of XAPI.  Older
> versions must still use the "vSwitchController" key in "other_config".
> Based on commits 37fee7 and 0ebd737 from the xs5.7 branch written by
> Ian Campbell.


Comparing this against the changes that it cross-ports, the only bit
that caught my eye was this:

> @@ -222,14 +226,15 @@ class VSwitchControllerDialogue(Dialogue):
>      def SetController(self, ip):
>          self.hostsInPool = 0
>          self.hostsUpdated = 0
> -        Task.Sync(lambda s: self._modifyPoolConfig(s, "vSwitchController", ip))
> +        Task.Sync(lambda s: self._modifyPoolConfig(s, ip or ""))

I don't know what the 'or ""' is intended to catch.

Assuming that's intentional, it looks like an OK crossport to me.

More information about the dev mailing list