[ovs-dev] [PATCH 4/4] xenserver: Ensure "service openvswitch status" returns appropriate error code

Justin Pettit jpettit at nicira.com
Mon Apr 12 20:01:08 UTC 2010


On Apr 12, 2010, at 9:59 AM, Ben Pfaff wrote:

> On Sun, Apr 11, 2010 at 11:18:35PM -0700, Justin Pettit wrote:
>> This command was returning success when vswitchd was not running.  Citrix's
>> automated test relies on this command to decide if the host uses OVS or
>> not.
> 
> This should be fixed already by commit a1864c5f8 'Ensure "service
> vswitch status" returns appropriate error code'.  The && ensures that
> the return code gets propagated correctly.

Right.  I hadn't though about the fact that the result of that would propagate out through the script.  We'll just need to be careful not to execute anything after that main "case" statement.  I killed this commit and pushed the rest.

--Justin






More information about the dev mailing list