[ovs-dev] [PATCH] xenserver: Fix ip_gre_mod modprobe issue in init script

Justin Pettit jpettit at nicira.com
Mon Apr 12 20:40:36 UTC 2010


On Apr 12, 2010, at 1:22 PM, Ben Pfaff wrote:

> On Mon, Apr 12, 2010 at 01:15:05PM -0700, Justin Pettit wrote:
>> The OVS kernel modules were moved to kernel/extra/openvswitch, but the
>> init script wasn't updated to look for the ip_gre_mod kernel module
>> there.  This commit fixes that.
> 
> Looks OK.
> 
> You didn't change anything here, but in init scripts I usually see
> system tools such as lsmod referred to through absolute paths,
> e.g. /sbin/lsmod on Fedora/RHEL/XenServer (Debian uses /bin/lsmod), so
> that might be a good additional change.


It seems like that is inconsistently done in the XenServer init scripts.  "/etc/init.d/functions", which our script sources, has the following code:

-=-=-=-=-=-=-=-=-=-
# Set up a default search path.
PATH="/sbin:/usr/sbin:/bin:/usr/bin"
export PATH
-=-=-=-=-=-=-=-=-=-

I think that should take care of it, unless you think there's some added benefit.

--Justin






More information about the dev mailing list