[ovs-dev] [PATCH] xenserver: Fix ip_gre_mod modprobe issue in init script

Ian Campbell Ian.Campbell at citrix.com
Tue Apr 13 09:36:48 UTC 2010


On Tue, 2010-04-13 at 09:44 +0100, Justin Pettit wrote:
> Apparently, the Linux GRE module is kind of buggy and supports
> different types of tunneling in different version.  This is an OVS
> version of GRE, which provides Ethernet-over-IP support all the way
> back to 2.6.18 and a consistent interface.  As I'm sure you're going
> to suggest, we should probably come up with a less generic/confusing
> name.  :-)

;-) I suppose fixing the Linux GRE stack wasn't an option?

I generally skip the stuff in datapath/linux-2.6/compat-2.6 when
integrating into our kernel tree since none of it seemed to be necessary
for 2.6.27 (apart from a few trivial tweaks). If this module is always
going to be used and isn't strictly part of a compat layer for the
in-kernel GRE stuff perhaps it would be better to pull it out of the
compat subdirectory?

Unfortunately it's too late to add this module to the XenServer 5.6
kernel but we'll need to figure out what to do here at some point.

Ian.

> Jesse did a major rewrite of the GRE stack, which he should be sending
> out for review tomorrow.  I'm not sure exactly what it will look like
> externally, but we'll make sure that its name is a bit clearer.
> 
> --Justin
> 
> 
> On Apr 13, 2010, at 1:38 AM, Ian Campbell wrote:
> 
> > Is this module only required when the base kernel doesn't already
> > include GRE support of its own? It looks as if XenServer 5.6 has
> > ip_gre.ko so I guess this is 5.5 specific?
> > 
> > Does any action need to be taken on 5.6 to ensure the module is loaded
> > when required? I notice the module has a different name under 2.6.27 to
> > what you appear to be using if that matters.
> > 
> > Ian.
> > 
> > On Mon, 2010-04-12 at 21:15 +0100, Justin Pettit wrote:
> >> The OVS kernel modules were moved to kernel/extra/openvswitch, but the
> >> init script wasn't updated to look for the ip_gre_mod kernel module
> >> there.  This commit fixes that.
> >> 
> >> CC: Paul Ingram <paul at nicira.com>
> >> ---
> >> xenserver/etc_init.d_openvswitch |    2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> 
> >> diff --git a/xenserver/etc_init.d_openvswitch b/xenserver/etc_init.d_openvswitch
> >> index 8b703fc..b7feb9b 100755
> >> --- a/xenserver/etc_init.d_openvswitch
> >> +++ b/xenserver/etc_init.d_openvswitch
> >> @@ -126,7 +126,7 @@ function insert_modules_if_required {
> >>     if [ "$ENABLE_BRCOMPAT" = "y" ] && [ -n "$BRCOMPATD_PIDFILE" ] && ! lsmod | grep -q "brcompat_mod"; then
> >>         action "Inserting brcompat module" modprobe brcompat_mod
> >>     fi
> >> -    if [ -f "/lib/modules/`uname -r`/kernel/net/openvswitch/ip_gre_mod.ko" ] && ! lsmod | grep -q "ip_gre_mod"; then
> >> +    if [ -f "/lib/modules/`uname -r`/kernel/extra/openvswitch/ip_gre_mod.ko" ] && ! lsmod | grep -q "ip_gre_mod"; then
> >>         action "Inserting ip_gre module" modprobe ip_gre_mod
> >>     fi
> >> }
> > 
> > 
> 






More information about the dev mailing list