[ovs-dev] [PATCH 2/2] ofproto: Make NXAST_RESUBMIT take header modifications into account.

Ben Pfaff blp at nicira.com
Tue Apr 13 17:13:49 UTC 2010


On Tue, Apr 13, 2010 at 12:59:24AM -0700, Justin Pettit wrote:
> This looks fine to me.  We will need to be careful that any new vendor
> actions that modify the flow also do this.  For example, Jesse will be
> adding a "set GRE key" vendor action very soon.  For now, I think it
> would be good to at least document this in the OFPAT_VENDOR case
> statement, and probably xlate_nicira_action() for good measure.  It
> just seems like the type of thing that could be easily overlooked.

That's a good idea.  I added this in xlate_nicira_action():

        /* If you add a new action here that modifies flow data, don't forget
         * to update the flow key in ctx->flow in the same key. */




More information about the dev mailing list