[ovs-dev] [PATCH 3/3] odp-util: Print bad action numbers in hexadecimal in format_odp_action().

Ben Pfaff blp at nicira.com
Tue Apr 13 23:50:48 UTC 2010


Given that dpif.c clears action numbers to 0xcccc it can be much less
mystifying to see that instead of 52428.
---
 lib/odp-util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/odp-util.c b/lib/odp-util.c
index 87ac92b..67ce413 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009 Nicira Networks.
+ * Copyright (c) 2009, 2010 Nicira Networks.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -90,7 +90,7 @@ format_odp_action(struct ds *ds, const union odp_action *a)
         ds_put_format(ds, "set_tp_dst(%"PRIu16")", ntohs(a->tp_port.tp_port));
         break;
     default:
-        ds_put_format(ds, "***bad action %"PRIu16"***", a->type);
+        ds_put_format(ds, "***bad action 0x%"PRIx16"***", a->type);
         break;
     }
 }
-- 
1.6.6.1





More information about the dev mailing list