[ovs-dev] [PATCH 07/16] dpif-linux: Clean up vports that are no longer in config.

[Ben Pfaff]

On Tue, Apr 13, 2010 at 10:41:09AM -0400, Jesse Gross wrote:
> If the config changes while ovs-vswitchd is not running it is possible
> that there could be some vports which are no longer needed but won't
> be destroyed when closed because they aren't open.  This deletes
> unneeded vports at the same time that we clean up unneeded datapaths.

Is it ever useful to keep around a vport that is attached to a dp at the
time of the datapath's destruction?  If we are going to unconditionally
delete them from userspace, would it be better to do that from the
kernel?

In dpif_linux_destroy(), should we really give up with an error if any
of the calls fail?  Would it be better to continue along the way and
finish up deleting the datapath before reporting the error?  I doubt the
callers actually retry, but they probably do really want to delete the
datapath.