[ovs-dev] [PATCHv2] netdev: Add support for "patch" type

Ben Pfaff blp at nicira.com
Thu Apr 15 16:34:28 UTC 2010


Thank you for the updated patch!

In create_patch(), || is treated as if it yields the first nonzero
value, but actually in C it always yields 0 or 1, so this will squash
all errno values to 1 (EPERM as it happens on Linux).

In setup_patch(), if you do care about unknown arguments, you could
check for shash_count(args) > 1.

In setup_patch(), I think that IFNAMSIZ - 1 would be a more accurate
maximum device name length, because IFNAMSIZE has to include the
trailing null byte.




More information about the dev mailing list