[ovs-dev] [PATCH 15/16] tunneling: Add userspace support for new GRE implementation.
blp at nicira.com
Thu Apr 15 17:57:29 UTC 2010
On Tue, Apr 13, 2010 at 10:41:17AM -0400, Jesse Gross wrote:
> Add a netdev that supports the new datapath GRE implementation.
> It currently coexists with the old implementation so it is named
In netdev_gre_create(), I think that the cast is unneeded on "(struct
In netdev_gre_reconfigure(), I would write &port_config instead of
"(struct gre_port_config *)ovm.config".
In netdev_gre_destroy(), I do not see why the xstrdup() is necessary.
In netdev_gre_update_flags(), I was surprised about NETDEV_LOOPBACK.
The only other reference I see to it is in netdev.h. I guess that we
should delete it. It is not, at any rate, a configuration parameter
that can be turned on and off.
"Review fatigue" set in when I arrived at the netdev_gre_poll_*()
functions. I guess that these are correct.
More information about the dev