[ovs-dev] [PATCHv2] netdev: Add support for "patch" type

[Jesse Gross]

On Thu, Apr 15, 2010 at 12:50 PM, Justin Pettit <jpettit at nicira.com> wrote:

> On Apr 15, 2010, at 9:34 AM, Ben Pfaff wrote:
>
> > In create_patch(), || is treated as if it yields the first nonzero
> > value, but actually in C it always yields 0 or 1, so this will squash
> > all errno values to 1 (EPERM as it happens on Linux).
>
> I did not know that.  (I originally wrote that as "Very interesting", but
> I'm not sure I actually feel that way.  ;-)  But seriously, thank you for
> teaching me that.)  Fixed.
>
> > In setup_patch(), if you do care about unknown arguments, you could
> > check for shash_count(args) > 1.
>
> Good point.  I added that.
>
> > In setup_patch(), I think that IFNAMSIZ - 1 would be a more accurate
> > maximum device name length, because IFNAMSIZE has to include the
> > trailing null byte.
>
>
> I don't know what I was thinking there.
>
> Thanks for the review.  I'll wait to hear back from Jesse before I push.


 This looks a lot better to me.  Thanks for going back over it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100415/ff34c792/attachment-0003.html>