[ovs-dev] [PATCH 08/16] datapath: Genericize hash table.

Ben Pfaff blp at nicira.com
Thu Apr 15 21:08:50 UTC 2010


On Thu, Apr 15, 2010 at 05:04:03PM -0400, Jesse Gross wrote:
> On Wed, Apr 14, 2010 at 7:54 PM, Ben Pfaff <blp at nicira.com> wrote:
> > I think that hash_seed is only used in flow.c, so that it should be
> > "static".  It's too bad that hash_seed can never change anymore; maybe
> > we should just use 0.
> 
> Yes, it should be static.  However, what do you mean that hash_seed can
> never change?  It is randomized when the module is loaded.  Since I don't
> expect that tables will be created and destroyed frequently it is
> essentially equivalent.

I mean that before it would change whenever a table was created or
destroy or grew or shrank.  Now it only changes if the machine is
rebooted.

It's not a big deal.




More information about the dev mailing list