[ovs-dev] [PATCH 08/14] in-band: Fix null pointer dereference.

Justin Pettit jpettit at nicira.com
Thu Apr 15 22:45:14 UTC 2010


Another good catch.  Thanks.

--Justin


On Apr 8, 2010, at 5:07 PM, Ben Pfaff wrote:

> Triggering this would require deleting the in-use datapath at just the
> right time, but we still don't want it to happen.
> ---
> ofproto/in-band.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ofproto/in-band.c b/ofproto/in-band.c
> index 219ab8d..7e2fc53 100644
> --- a/ofproto/in-band.c
> +++ b/ofproto/in-band.c
> @@ -410,7 +410,7 @@ in_band_msg_in_hook(struct in_band *in_band, const flow_t *flow,
>         }
> 
>         local_mac = get_local_mac(in_band);
> -        if (eth_addr_equals(dhcp->chaddr, local_mac)) {
> +        if (local_mac && eth_addr_equals(dhcp->chaddr, local_mac)) {
>             return true;
>         }
>     }
> -- 
> 1.6.6.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list