[ovs-dev] [PATCH 1/4] bridge: Don't log warnings when revalidating.

Ben Pfaff blp at nicira.com
Fri Apr 16 00:11:56 UTC 2010


The rest of the warnings along this path follow this rule, but this one
didn't.  Make it consistent.
---
 vswitchd/bridge.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 620689f..baa889b 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -2223,10 +2223,12 @@ process_flow(struct bridge *br, const flow_t *flow,
 
     /* Drop frames on ports reserved for mirroring. */
     if (in_port->is_mirror_output_port) {
-        static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
-        VLOG_WARN_RL(&rl, "bridge %s: dropping packet received on port %s, "
-                     "which is reserved exclusively for mirroring",
-                     br->name, in_port->name);
+        if (packet) {
+            static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
+            VLOG_WARN_RL(&rl, "bridge %s: dropping packet received on port "
+                         "%s, which is reserved exclusively for mirroring",
+                         br->name, in_port->name);
+        }
         goto done;
     }
 
-- 
1.6.6.1





More information about the dev mailing list