[ovs-dev] [PATCH 16/16] tunneling: Remove old GRE implementation.
jesse at nicira.com
Fri Apr 16 13:54:43 UTC 2010
On Thu, Apr 15, 2010 at 2:04 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Apr 13, 2010 at 10:41:18AM -0400, Jesse Gross wrote:
> > The new GRE implementation provides a complete drop in replacement
> > for the old Linux based implementation. Therefore, remove the
> > old implementation and rename "grenew" to "gre".
> Looks good.
> I hope that you verified that any header file still in
> datapath/linux-2.6/compat-2.6 is listed in some *_headers in Modules.mk.
> (Otherwise they get left out by "make dist" and cause surprises.)
I double checked - I think I got everything.
> It looks like there is no module for gre anymore. I guess that means
> that gre is built into the base openvswitch_mod now. I wasn't paying
> attention in previous patches, I guess, because I didn't notice that.
Yeah, it's now in the main module. I am planning on allowing external
modules to register vport providers but it's not there yet. I might break
it out at that point.
> This is quite a patch series. Wow.
Thanks for reviewing it all and for the feedback - I know that's quite a lot
of work as well.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the dev