[ovs-dev] [PATCH] CodingStyle: Drop advice about breaking lines before binary operators.

Ben Pfaff blp at nicira.com
Mon Apr 19 21:37:59 UTC 2010


I like the style that was prescribed here--I find it slightly easier to
read--but everyone else who submits code seems to prefer breaking
lines after binary operators instead.  No point in fighting the tide.
---
 CodingStyle |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/CodingStyle b/CodingStyle
index f4765ad..bbb492e 100644
--- a/CodingStyle
+++ b/CodingStyle
@@ -412,13 +412,8 @@ Exception 1: Put a space after (but not before) the "sizeof" keyword.
 Exception 2: Put a space between the () used in a cast and the
 expression whose type is cast: (void *) 0.
 
-  Break long lines before binary operators and the ternary operators ?
-and :, rather than after them, e.g.
-
-    if (first_long_condition() || second_long_condition()
-        || third_long_condition())
-
-and
+  Break long lines before the ternary operators ? and :, rather than
+after them, e.g.
 
     return (out_port != VIGP_CONTROL_PATH
             ? alpheus_output_port(dp, skb, out_port)
-- 
1.6.6.1





More information about the dev mailing list