[ovs-dev] [PATCH 2/2] xenserver: Factor redundancy out of /etc/init.d/openvswitch.

Ben Pfaff blp at nicira.com
Mon Apr 26 23:49:43 UTC 2010


On Mon, Apr 26, 2010 at 04:29:59PM -0700, Justin Pettit wrote:
> On Apr 26, 2010, at 2:18 PM, Ben Pfaff wrote:
> 
> > +    elif test -n "$strace_log"; then
> > +        local mode=strace
> > +        set -- $nice strace -o "$strace_log" $strace_opt "$@"
> 
> I think you want to blow away this "$nice", since the niceness gets set later.

Thanks, yes, I got rid of all the "$nice"s now.

> > +        install -d -m 755 -o root -g root `dirname $VSWITCHD_PIDFILE`
> 
> Did you want that to be "$pidfile" instead of "$VSWITCHD_PIDFILE"?

Yes, thanks.

> > +        set -- $nice "$@" --pidfile="$pidfile" --detach $monitor_opt --no-chdir
> 
> > "$VSWITCHD_RUN_DIR"
> 
> Did you want to use "$run_dir" here?  [...]

I'm puzzled.  I couldn't find any use of "$VSWITCHD_RUN_DIR" anywhere in
the file.  In the original email I only see it in deleted lines.  Where
did you see it?

> > +        # Start in background and force a "success" message
> > +        action "Starting ovs-vswitchd with $mode debugging" true
> 
> Did you want to print "`basename $BINARY`" instead of "ovs-vswitchd"?

Yes, thanks.

> xenserverd isn't using this fancy new start_daemon() stuff.  Is that on purpose?

Oops.  Fixed.  I changed the whole start_xenserverd function to:

function start_xenserverd {
    start_daemon XENSERVERD "$xenserverd"
}

I'll wait to push this until I hear back.  Thanks again.




More information about the dev mailing list