[ovs-dev] [PATCH 2/2] ofproto: Avoid buffer copy in OFPT_PACKET_IN path.

Ben Pfaff blp at nicira.com
Tue Apr 27 16:42:18 UTC 2010


On Mon, Apr 26, 2010 at 11:51:24PM -0700, Justin Pettit wrote:
> On Apr 26, 2010, at 4:28 PM, Ben Pfaff wrote:
> 
> > I agree with your other comments, but they no longer apply to the newer
> > version.
> 
> You forgot to add "See Figure 1."

I didn't mean to be rude.  I hope it didn't come across that way.
(Text communication has so little inflection that one has to add an
extra couple of steps of politeness or it is so easy to misinterpret.)

> > 
> > +/* Takes 'packet', which has been converted with do_convert_to_packet_in(), and
> > + * finalizes its content for sending on 'ofconn', and passes it to 'ofconn''s
> > + * packet scheduler it for sending.
> 
> I think you can remove that last "it".

Thanks, fixed.

> > -    /* Send. */
> > -    rconn_send_with_limit(ofconn->rconn, opi, ofconn->packet_in_counter, 100);
> > +    /* Figure out how many of the packet to send. */
> 
> Did you mean "much" instead of "many"?

Yes, thanks.  Fixed.

> Other than those nits, it looks good to me.

Great.

Jean: I finally pushed this optimization.  (It's too bad it took so
long.)




More information about the dev mailing list