[ovs-dev] [PATCH 2/2] xenserver: Factor redundancy out of /etc/init.d/openvswitch.

Ben Pfaff blp at nicira.com
Tue Apr 27 16:43:09 UTC 2010


On Mon, Apr 26, 2010 at 05:03:45PM -0700, Justin Pettit wrote:
> On Apr 26, 2010, at 4:49 PM, Ben Pfaff wrote:
> 
> >>> +        set -- $nice "$@" --pidfile="$pidfile" --detach $monitor_opt --no-chdir
> >> 
> >>> "$VSWITCHD_RUN_DIR"
> >> 
> >> Did you want to use "$run_dir" here?  [...]
> > 
> > I'm puzzled.  I couldn't find any use of "$VSWITCHD_RUN_DIR" anywhere in
> > the file.  In the original email I only see it in deleted lines.  Where
> > did you see it?
> 
> Weird.  Maybe I selected and dragged my mouse and it got dumped
> there somehow.  I don't see it, either.

OK, thanks.

I pushed these fixes out on top of the pre-review version that got
pushed yesterday by accident.




More information about the dev mailing list