[ovs-dev] Kernel BUG on Xen

Jesse Gross jesse at nicira.com
Fri Apr 30 01:02:32 UTC 2010


On Wed, Apr 28, 2010 at 7:59 AM, Nick Couchman <Nick.Couchman at seakr.com>wrote:

> Well, this seems to keep things from crashing.  >
> > Here's another version of the patch.  It may be slightly more robust and
> > also contains some additional logging.  It against the master branch (not
> > the previous patch):
> >
>
>
> This patch seems to keep it from crashing, and produces lots of output for
> those printk's you added in.  Below is some of the output.
>

That's great that the patch solves the problem.  I'll send out a more
finished version shortly.

Ian, the skb_pull_up_to() function that exhibits this problem was copied
directly from Xen so I'm concerned that this issue has wider significance.
 Some versions of skb_checksum_setup() (such as the one in openSUSE) simply
check whether everything is within the skb linear data area and don't pull,
which avoids the problem.  However, the version in XCP does the exact same
thing as OVS.

Is there a reason for the open coding in skb_pull_up_to() rather than using
pskb_may_pull(), which would seem to be more canonical and adds a check to
prevent running off the end of the packet?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100429/fd352c31/attachment-0003.html>


More information about the dev mailing list