[ovs-dev] [VLAN/SNAP 3/3] dpif-netdev: Properly track whether there is a vlan header.

Jesse Gross jesse at nicira.com
Thu Aug 5 17:41:22 UTC 2010


On Wed, Jul 28, 2010 at 2:01 PM, Ben Pfaff <blp at nicira.com> wrote:

> It looks to me like the current dpif-netdev implementation doesn't handle
> the case where a packet comes in without a VLAN and then is subjected to
> multiple ODPAT_SET_VLAN_* operations.  dp_netdev_modify_vlan_tci() just
> checks the flow key each time to see whether there's a VLAN, but it doesn't
> update the flow key to note that there is now a VLAN.
>
> One fix would be to update the flow key, but it's "const" these days.
> Instead, add a check for whether the Ethernet type is ETH_TYPE_VLAN,
> which should be equivalent.
>

Looks good.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100805/4c070391/attachment-0003.html>


More information about the dev mailing list