[ovs-dev] [VLAN/SNAP 2/3] dpif-netdev: Tolerate undersized packets.

Ben Pfaff blp at nicira.com
Tue Aug 10 19:41:56 UTC 2010


On Tue, Aug 10, 2010 at 11:53:39AM -0700, Ben Pfaff wrote:
> On Thu, Aug 05, 2010 at 01:41:20PM -0400, Jesse Gross wrote:
> > On Wed, Jul 28, 2010 at 2:01 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > > +    if (packet->size < sizeof(struct eth_header)) {
> > > +        return;
> > > +    }
> > >
> > 
> > Should we just discard packets that are less than Ethernet header size in
> > dp_netdev_port_input()?  It seems that nothing good will come of them.  We
> > already do this in dpif_netdev_execute().
> 
> That's better, thanks.

Jesse, do you have any notion of whether dp_process_received_packet() in
datapath/datapath.c should have a similar check for too-short packets?
Presumably such packets cannot come from physical Ethernet devices, and
at least the tuntap code has a check to ensure that too-short packets
cannot come from it either, but...?




More information about the dev mailing list