[ovs-dev] [PATCH 2/2] bridge: Don't pay attention to columns that vswitchd doesn't need.

Justin Pettit jpettit at nicira.com
Wed Aug 11 07:04:19 UTC 2010


On Jul 19, 2010, at 4:30 PM, Ben Pfaff wrote:

> Not replicating unneeded columns has some value in avoiding CPU time and
> bandwidth to the database.  In ovs-vswitchd, setting cur_cfg! as write-only

Is the bang significant?  Is it factorial?  Is it just a misplaced sense of excitement like "Yahoo!"?

> +                /* Didn't really changed but the OVSDB monitor protocol always
> +                 * includes every value in a row. */

changed -> change

> +    ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);

I guess it shouldn't be changing once the bridge has been created, but do we not care if fake_bridge has changed?

This series will be a great improvement for systems with a lot of configuration state.  Thanks!

--Justin






More information about the dev mailing list