[ovs-dev] [PATCH 2/2] bridge: Don't pay attention to columns that vswitchd doesn't need.

Ben Pfaff blp at nicira.com
Wed Aug 11 22:30:08 UTC 2010

On Wed, Aug 11, 2010 at 12:04:19AM -0700, Justin Pettit wrote:
> On Jul 19, 2010, at 4:30 PM, Ben Pfaff wrote:
> > Not replicating unneeded columns has some value in avoiding CPU time and
> > bandwidth to the database.  In ovs-vswitchd, setting cur_cfg! as write-only
> Is the bang significant?  Is it factorial?  Is it just a misplaced
> sense of excitement like "Yahoo!"?

Typo.  Thanks, removed.

> > +                /* Didn't really changed but the OVSDB monitor protocol always
> > +                 * includes every value in a row. */
> changed -> change

Thanks, fixed.

> > +    ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
> I guess it shouldn't be changing once the bridge has been created, but
> do we not care if fake_bridge has changed?

The vswitch doesn't care about fake_bridge at all, and it never reads or
writes that column.  Its only purpose is to tell ovs-vsctl that it
should pretend that that port is a bridge.

> This series will be a great improvement for systems with a lot of
> configuration state.  Thanks!

Thank you for the review.

More information about the dev mailing list