[ovs-dev] [PATCH 1/2] ovsdb-idl: Make it possible to omit or pay less attention to columns.

Ben Pfaff blp at nicira.com
Wed Aug 11 22:40:18 UTC 2010


On Wed, Aug 11, 2010 at 03:30:20PM -0700, Justin Pettit wrote:
> On Aug 11, 2010, at 3:26 PM, Ben Pfaff wrote:
> >>> + * This function should be called after ovsdb_idl_create(), but before the
> >>> + * first call to ovsdb_idl_run().  This function is mutually exclusive with
> >>> + * ovsdb_idl_omit() for any given column. */
> >>> +void
> >>> +ovsdb_idl_set_write_only(struct ovsdb_idl *idl,
> >>> +                         const struct ovsdb_idl_column *column)
> >>> +{
> >>> +    ovsdb_idl_set_mode(idl, column, OVSDB_IDL_MODE_WO);
> >>> +}
> >> 
> >> It might be nice to note that there's no turning back once this
> >> function has been called, based on the assertion above.
> > 
> > Doesn't the comment already say that?
> 
> I took the comment to mean that it can't be in both the omit and
> write-only state...not that the program will assert() if you try to
> change it.

I see.  I'll improve it.




More information about the dev mailing list