[ovs-dev] [PATCH] ofproto: Add support for NXAST_RESUBMIT recursion.

[Ben Pfaff]

On Thu, Aug 12, 2010 at 02:59:05PM -0700, Justin Pettit wrote:
> On Aug 12, 2010, at 2:26 PM, Ben Pfaff wrote:
> 
> > @@ -2474,7 +2478,7 @@ lookup_valid_rule(struct ofproto *ofproto, const flow_t *flow)
> > static void
> > xlate_table_action(struct action_xlate_ctx *ctx, uint16_t in_port)
> > {
> > -    if (!ctx->recurse) {
> > +    if (ctx->recurse < MAX_RESUBMIT_RECURSION) {
> >         uint16_t old_in_port;
> >         struct rule *rule;
> 
> Do you think we should print some sort of rate-limited log message or
> at least increment a counter?  This is a great check to have, but I'm
> afraid that it could lead to "mysterious" loss of packets from a
> controller writer's perspective.

Good idea.  Done and pushed.