[ovs-dev] [runt-flows 4/8] datapath: Free up flow_extract() return value for reporting errors.

Jesse Gross jesse at nicira.com
Thu Aug 26 04:33:12 UTC 2010

On Fri, Aug 13, 2010 at 1:55 PM, Ben Pfaff <blp at nicira.com> wrote:
> flow_extract() can fail due to memory allocation errors in pskb_may_pull().
> Currently it doesn't return those properly, instead just reporting a bogus
> flow to the caller.  But its return value is currently in use for reporting
> whether the packet was an IPv4 fragment.  This commit switches to reporting
> that in the skb itself so that the return value can be reused to report
> errors.
> Signed-off-by: Ben Pfaff <blp at nicira.com>

Putting it in the skb seems a little bit overkill seeing as it is only
passed between two functions but it doesn't really matter.  Actually,
in the future the flow key will be in the skb as well so I guess it is
consistent at least.

More information about the dev mailing list