[ovs-dev] [rfc 5/6] ovs-datapath: use dev instead of NETDEV_DEV_MEMBER

Simon Horman horms at verge.net.au
Thu Aug 26 11:52:55 UTC 2010


On Wed, Aug 25, 2010 at 09:33:07PM -0700, Jesse Gross wrote:
> On Wed, Aug 25, 2010 at 12:08 AM, Simon Horman <horms at verge.net.au> wrote:
> > This saves dragging in a compatibility #define
> >
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Is this the only piece that depends on the compat/ directory on the
> latest kernel source?

At this stage yes, I believe so.

> If so, I might be tempted to just put in the
> #ifdef here for consistency.  We already have a lot of them in this
> file and we might as well make things consistent.  Obviously it will
> get ripped out when we merge upstream.

I'd prefer not to add the #ifdef, but its not a strong preference.
As you say, there is lots of compatibility code to be removed
regardless.





More information about the dev mailing list